[busy][2.5.6] deleted post loading, reward balance refresh

in #utopian-io5 years ago (edited)

Project Information

This is a collection of 2 bugs of Busy 2.5.6 (current). I've submitted the issues, one with the relevant code for the bugs; the other with a PR. Based on my previous experience, sometimes merges take too long (especially if submitted at the beginning of the month) so I just submit this without further waiting for the PR to be merged.

Issues:

Expected behavior

  1. When a user access a deleted post/comment, Busy should show that it is deleted (or at least stop waiting for loading)
  2. Reward Balances should be updated when claimed externally (e.g., on Steemit.com, steemauto, API).

Actual behavior

  1. Busy waits forever for loading. Users cannot tell if it's actually loading or deleted.
  2. Reward Balances are not updated when claimed externally.

How to reproduce

infinite waiting for deleted posts
reward balance refresh
  • Log in to Busy.org with an account that has claimable balances.
  • Claim the balance externally (e.g., on Steemit.com, steemauto, API).
  • Click the "Claim rewards" button, then you can see no update.
  • App version: 2.5.6
  • Browser version: Any
  • Operating system: Any

Recording Of The Bug

infinite waiting for deleted posts

Visit https://busy.org/@guest123/5rhhdo-test (deleted post, don't be curious about the content, this was just a test posting :) Then you'll see the infinite loading icon.

reward balance refresh

If the claimable balances are claimed externally, then even if click the "Claim rewards" button, it only tries to re-claim but doesn't update anything.

Cause and Fixes

infinite waiting for deleted posts

https://github.com/busyorg/busy/blob/58e1dc1f17bb33f82c40c036a0196218c31bf39d/src/client/helpers/postHelpers.js#L11

While there is a code for deleted post, it is not properly used. In contrast, isPostTaggedNSFW works well. That is, for those pages, Busy shows a page with the special message.

Also, when a post is deleted, title and body is '' and 'deleted' But this isn't the problem itself as far as I debugged. The function itself isn't called.

reward balance refresh

https://github.com/busyorg/busy/pull/2184

When the claim is failed, currently it doesn't refresh the balance. So I fix this. After the fix, if claimed externally, it shows the updated amount if there are new balances.

GitHub Account

https://github.com/economicstudio

Sort:  

Hi @blockchainstudio, thanks for making this contribution.

I was able to replicate the behaviors you described in this post. The "Claim Rewards" button does not update the wallet immediately when clicked. I noticed this after the rewards in my account were claimed externally via steemauto. I was also able to reproduce the issue regarding deleted posts by following the post link you provided.

The steps provided were easy to follow and replicate.

I see that you have proposed a fix for these issues and made pull requests towards that effect. I like the manner in which you analysed and explained the cause. I also must commend the measures you have taken towards implementing the fix.

Thanks again for this contribution.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Hi @fego, thank you for your review!

Thank you for your review, @fego! Keep up the good work!

In Korean: 요새 좀 계속 바빠서 글을 못쓰다보니 또 관성에 더 안쓰게 될 것 같아 억지로 이전에 리포트해놓은 거라도 올립니다ㅎㅎ Busy는 확실히 월말에 몰아서 일하는듯. 월급 그냥 받기 미안하니까 월말에 몰아서 작업하는 모습이 딱 보입니다^^

자잘한 버그입니다: 1. 삭제된 글을 삭제되었다고 안보여주고 계속 로딩시도해서 이게 네트웍 문제인지 글이 없는 것인지 알수가 없습니다. 2. 보상 claim할때 외부에서(스팀오토든 어떤 프로그램에 의해) 먼저 claim이 되버려도 claim버튼을 눌러도 refresh가 안되고 계속 그대로입니다. 클레임이 실패해도 로딩을 다시 하게 바꾸어서 코드보내놓은 상태입니다.

댓글 업데이트가 겁나 느리네요ㅎㅎ 안적힌줄 알고 열받아하고 있었는데 다시 적기 귀찮아서 포기하려던 참인데 올라왔군요ㅎㅎ 경비절감하면서부터 이런 refresh들이 다 느리게 되는듯ㅠㅠ 또 어쩔때는 바로바로 되네요ㅎㅎ 노일관성의 매력.

감사합니다! 어제 비지가 이상하더라구요 ^^

비지는 요새 계속 안좋은 것 같아요. 신기능은 https://staging.busy.org 에서 체험하실 수 있습니다^^ 가끔 한쪽이 더 잘되기도 해요.

넵!! 잘 되는거 같아요 감사합니다 ^^

짱짱맨 호출에 응답하였습니다.

블록님 혹시 팔로어 리스트 예전처럼 가나다순으로 볼 수는 없나요?

저도 사실 알파벳순을 선호하는데 hivemind이전하면서 시간순으로 결국 굳어졌네요. 이전에 github에도 제안하긴 했는데 그냥 시간순도 하나의 정보아니냐고 결국 굳어졌어요ㅠㅠ UI에서 소팅기능을 제공하면 좋을텐데 스팀잇이나 비지나 둘다 그걸 해줄 것 같진 않죠?ㅎㅎ

아. 그렇군요. T^T 불편해도 그냥 써야겠네요. 제가 알파벳순을 가나다순이라고 썼네요.ㅋㅋ 요즘 이렇게 정신이 없ㅇ...ㅋㅋ 늘 친절한 댓글 감사합니다.

Hi @blockchainstudio!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @blockchainstudio!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.35
TRX 0.12
JST 0.040
BTC 70601.11
ETH 3576.21
USDT 1.00
SBD 4.78