bug found in LM-videodownloader The application crashes when I try to rename any file during the download

in #utopian-io5 years ago

Project Information

Expected behavior

The file name should be changed when I try to rename any file during the download

Actual behavior

The application crashes when I try to rename any file during the download

How to reproduce

1-Download the app and open it
2- Click on the YouTube icon so you will go to YouTube
3-Then apply any video or audio to download
4-Click the 3 verticals line on the top left
5- click on downloads
6- select the In Progress tab and click on the edit icon
7-and now click on ok button
8- see bug

  • Browser/App version: v1.0.1
  • Operating system: 6.0.1
  • Smartphone: Galaxy j7

Recording Of The Bug

20190506_130010

My Github Account

https://github.com/facebook-786

Beneficiaries

Logcat

E/AndroidRuntime(11523): FATAL EXCEPTION: main

E/AndroidRuntime(11523): Process: marabillas.loremar.lmvideodownloader, PID: 11523

E/AndroidRuntime(11523): java.lang.ArrayIndexOutOfBoundsException: length=12; index=-1

E/AndroidRuntime(11523): at java.util.ArrayList.get(ArrayList.java:310)

E/AndroidRuntime(11523): at marabillas.loremar.lmvideodownloader.download_feature.lists.DownloadQueues.renameItem(DownloadQueues.java:179)

E/AndroidRuntime(11523): at marabillas.loremar.lmvideodownloader.download_feature.fragments.DownloadsInProgress$DownloadItem$2$1.onOK(DownloadsInProgress.java:466)

E/AndroidRuntime(11523): at marabillas.loremar.lmvideodownloader.utils.RenameDialog.onClick(RenameDialog.java:56)

E/AndroidRuntime(11523): at com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:166)

E/AndroidRuntime(11523): at android.os.Handler.dispatchMessage(Handler.java:102)

E/AndroidRuntime(11523): at android.os.Looper.loop(Looper.java:135)

E/AndroidRuntime(11523): at android.app.ActivityThread.main(ActivityThread.java:5910)

E/AndroidRuntime(11523): at java.lang.reflect.Method.invoke(Native Method)

E/AndroidRuntime(11523): at java.lang.reflect.Method.invoke(Method.java:372)

E/AndroidRuntime(11523): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1405)

E/AndroidRuntime(11523): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1200)

Sort:  

Hi @facebok, thanks for making this contribution.

I see it's been accepted by the PO and fixed in these commits -
https://github.com/hikikomoriphoenix/LM-videodownloader/commit/8f132f8c5e6bd051f5e3b00e34f94bc8cf481d52
https://github.com/hikikomoriphoenix/LM-videodownloader/commit/af32e8f140bb14db0df9d2322134630a7c84f0b9

I believe the crash log was instrumental to solving this. Although, here I think the user story strange. Strange because I doubt if it was originally built to allow for renaming a file that is still being downloaded. Great that the PO could fix it.

Your English grammar still leaves more to be desired. Each time I review these reports I look to your recording for direction. I still hope there will be improvements soon..

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Thank you for your review, @fego! Keep up the good work!

Congratulations @facebok! You have completed the following achievement on the Steem blockchain and have been rewarded with new badge(s) :

You published more than 20 posts. Your next target is to reach 30 posts.
You made your First Vote

You can view your badges on your Steem Board and compare to others on the Steem Ranking
If you no longer want to receive notifications, reply to this comment with the word STOP

To support your work, I also upvoted your post!

Do not miss the last post from @steemitboard:

SteemitBoard - Witness Update
SteemitBoard to support the german speaking community meetups
Vote for @Steemitboard as a witness to get one more award and increased upvotes!

Hi @facebok!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server

Hey, @facebok!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.26
TRX 0.11
JST 0.033
BTC 64678.67
ETH 3086.68
USDT 1.00
SBD 3.87