More bug fixes into Steemit Condenser

View this post on Hive: More bug fixes into Steemit Condenser

---

Firstly thank you @steemitblog for giving me the title of Most Valuable Programmer of the week for my last set of contributions to the Steemit Condenser app codebase.

Some more of my PR have been accepted and merged into the Steemit Condenser.

Repository

https://github.com/steemit/condenser

Bug Fixes

Unable to click the resteem button #3346 by @timcliff

This bug has been fixed in Fixes #3346 - Allow more space for the post footer #3370

The fix was to simply increase the width of the container around the footer of the blog posts to allow more space for the links and buttons to render in a single line and not overlap on top of one another.

Comment layers are not visible enough #3195 by @therealwolf

Currently, we only have this little dot showing us on which comment-level/layer we are, which is not visible enough IMO. I actually didn't know it existed, because I didn't see it until @eonwarped told me about it...

The fact that comment layers are not well defined is a known issue and some phishing scammers have used this to their advantage in the past. It is also an issue that was handled by my Steemed Phish Chrome Extension:

What I proposed was to display a border to each comments in the following way:

The proposed solution was submitted in Fixes #3195 - Adds border around the components of a comment block #3332

Thank you @roadscape for helping with applying the theme for night mode and raising a bug in the implementation. A new PR was created to work on a final work in Fix border issues with comments #3393

The bug was to do with the way the Condenser handles downvoted comments. When a comment is downvoted, its HTML block was also assigned the collapsed class in order to hide the style on the body and footer block. However, the block was not really collapsed as you could still see the replies to the downvoted comment. This created issues with those replies as their content was displayed but the border wasn't applied.

The solution was to not apply the collapsed class to the comment block but try replicate the expected result by adding new classes. Here I introduced a Comment__block class to target the DIV container that holds the content and footer for the current comment not the one for its replies. I also introduced the revealed class for when you click on the Reveal comment on a downvoted comment, this would allow to also apply the border to it when it appears.

The dots mentioned by @therealwolf in his issue are also removed as they don't serve any purpose anymore with this new design.

Along with the Javascript code, CSS have also been modified to achieve the final behaviour.

In the CSS sample above, I added the .Comment__block CSS selector to the .Comment.collapsed selector so that it applies the collapsed style to only the content of the actual comment being collapsed and not to its children which would affect our border style.

I also needed to apply the same style as collapsed comments to comments that are downvoted but not revealed.

This was a tricky one but worth it I believe.

No coding involved

This section is for reporting some of my work done on reviewing issues which didn't needed coding.

Resteem on comments #2994 by psoscrypto

When you access to repleis option and click on a replei there is a resteem button that generate an error if you try to resteem that comment

This issue has apparently already been solved by a previous deployment.

Html parsing does not place line breaks correctly near images #3210 by @howo

We agreed that this is a no issue and it was an expected behaviour.

Logged in users shouldn't get: "Join... Sign up.Get STEEM!" message #2999 by @gandalf

This bug was raised on August 31st 2018 and since the split to Condenser + Wallet app, it is not an issue anymore.

GitHub Account

https://github.com/quochuy

Credits

Dividers by Lewis Keogh