You are viewing a single comment's thread from:

RE: steem-scot - a distributor for Smart Contract Organizational Token

in #utopian-io5 years ago (edited)

I haven't really been keeping up with the Steem Engine stuff, nor do I really have any interest in all these tokens popping up (seems like every app has their own one nowadays). However, I still think it's always cool to see you, and others, developing things for other (Steem-based) projects!

As for the code:

  • Would've been nice if you included some of the comments in this post in the actual code itself - it's relatively difficult to read it without.
  • Good to see you included instructions for the config at least.
  • Overall high quality code, but could use some refactoring to comply with PEP8 for example, and maybe some magic numbers could be made into constants instead.
  • Including some tests could be beneficial.

Will be interesting to see you add some more configuration examples, as well as timezone support, so I'm looking forward to future updates!


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for your review, @amosbastian! Keep up the good work!

Coin Marketplace

STEEM 0.29
TRX 0.12
JST 0.032
BTC 63506.20
ETH 3065.87
USDT 1.00
SBD 4.04