You are viewing a single comment's thread from:
RE: [ Swapsteem Development ] - Enabled Trade reviews for Buyers and Sellers
It's great to see you are actively working on improving Swapsteem and adding needed features, like the ability to leave a review!
A couple of things about the code:
- It's cool to see you are now using JSDoc style comments for functions!
- You might want to change "http://swapsteem-api.herokuapp.com/reviews/" to a constant, in case you change servers / the API changes.
- There's a lot of stuff like
res[0],res[1],data[1]etc., which is pretty confusing for someone like me who doesn't know much about your code base. Idk if that could be made more readable somehow, but if it can, then definitely think about it. - The URL attached to the repository (http://swapsteem.online) doesn't work. It would also be great if you, or someone else, added installation instructions, so people can easily set up Swapsteem locally.
Other than that I don't really have much to say other than keep up the great work!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Hey @amosbastian, Thanks for these suggestions. I will more take care about these points next time.
Posted using Partiko Android
Thank you for your review, @amosbastian! Keep up the good work!