You are viewing a single comment's thread from:
RE: Update Of PHP Graphene Node Client [v5.1.2 - v5.2.0]
Welcome back! It's cool to see you guys are still actively working on this, as I remember seeing some posts about this project before. Here is some feedback:
- In the comparison there are some commits > 14 days old - even if we are sort of lenient with this, try and keep it below.
- Some magic numbers like
16511and variables calledn2,n3etc. - could make into constants and make more descriptive respectively. - Could provide a description of what the function does instead of only having the arguments' names and types.
- Some funny indentation in the lists. Is lining up everything like this common in PHP?
Am interested to see what kind of features you guys add next. Any specific plans?
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Hi :)
Thanks for feedback!
It is my style more than PSR, but at most it corresponds to PSR =)
I do not have so much time as before and i am working ander other project - subchain for steem/viz chains.
i have some ideas about improvements for lib and i will add it in future
It's the 2nd time this week I've seen indentation like this, pretty funny. It reminds me of what I used to do when I first started programming because I thought it looked nice, and then someone told me off lol.
))) it is
Thank you for your review, @amosbastian! Keep up the good work!