You are viewing a single comment's thread from:
RE: SteemFlagRewards bot: Dedicated configuration file and code restructuring
Nice cleanup, @crokkon.
Looks like it also helps to make it easier to contribute to the repository.
Small note:
Regarding this type of check, I find it more convenient to use groups for the permissions. (Ex: creating a editors group in the discord, and check for the user has that role.)
Since everyone do that in strict ID checks, wondering is there a specific reason for that? :)
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thanks for the review, Emre! The main reason for using discord user IDs here is that is was like this before and I didn't want to introduce conceptual changes during this refactoring phase. Using a dedicated discord role is indeed a good idea here - thanks! Roles vs. ID checks is a bit a trade-off between where the setup and config is done and stored. User IDs allow for a minimal discord setup, any bare server can be used for testing. It may need adjustments in the bot config but all config is then under version control. Testing with roles may need fewer bot config changes but requires the discord server to be prepared accordingly - > out of git. Members wouldn't be revealed with roles, if this is considered sensitive information, though...
Thank you for your review, @emrebeyler! Keep up the good work!