You are viewing a single comment's thread from:

RE: Add modal preview for activity Report from database, multiplle upload picture features, and sidebar revision

in #utopian-io5 years ago

Thank you for your contribution. I wouldn't suggest your squeeze all your changes into one-single commit. Instead, it is better to git checkout -b a new branch, have several commits, each commit is dedicated for its purpose, and merge to your master branch.

  1. The code needs to be better formatted. e.g. Some has additional blank lines, and the code indention is not consistent.
  2. some functions are hard to understand without comments, for example: tambah
  3. The sleep(3); in upload() is a code smell.
  4. You have mixed the PHP logics code and HTML presentation. It is better to use some PHP frameworks to separate the logics from UI.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.27
TRX 0.11
JST 0.030
BTC 71152.89
ETH 3805.51
USDT 1.00
SBD 3.49