You are viewing a single comment's thread from:

RE: [Drugwars] Introducing Mike: Real time battle notifications on Discord

in #utopian-io5 years ago

Thank you for your contribution. I have to admit that I spent quite some time learning how to play this game, and it is fun!

I have some concerns about the performance. If there are quite a number of subscribers, does this Python library have impact on the server or does it have delays on sending notifications? You might want to have a separate queue for sending notification. The await still blocks the function execution.

Great to see you have tests! You could add some unit tests for historic data, as they are immutable on the steem blockchain which is great to test the TxListener.handle_operation() which I think it is important.

Your code looks great and it is a text-book example for learning Python, Steem Blockchain and how to create a discord bot. Thanks for that.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for your review, @justyy! Keep up the good work!

Coin Marketplace

STEEM 0.29
TRX 0.12
JST 0.034
BTC 62934.82
ETH 3119.20
USDT 1.00
SBD 3.86