You are viewing a single comment's thread from:

RE: Minecolonies & The Library

in #utopian-io6 years ago

Thank you very much for your contribution. I can see you have have some string constants in your source code this will have potential problems e.g. string comparison case inconsistency. You could use enum type which I think could be better and make your code more readable. Also, boolean parameter is kinda code smell you could have putToSleep or wakeMeUp method instead.

Overall, +1 for comments and getters/setters for private attributes!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Hi, thanks for your review, we actually use most of these Strings because we need these as resource strings as well to find the respective files (blockstates, models, textures, names, etc). Else we could use Enums, that's correct.

Thank you for your review, @justyy!

So far this week you've reviewed 3 contributions. Keep up the good work!

Coin Marketplace

STEEM 0.29
TRX 0.12
JST 0.033
BTC 63852.87
ETH 3135.82
USDT 1.00
SBD 3.83