You are viewing a single comment's thread from:
RE: Introducing Steem Multiple Authority Manager
Thank you for your contribution! Great work.
- You might want to check the input using
steem.utils.validateAccountNamecurrently, any invalid account names including the prefix @ will cause aTypeError: Cannot read property 'name' of undefined at f.database.getAccounts.then (app.js:1)error in the console - which is slient to users. - In fact, would it be better if your login requires actual validation via
steemconnectso that users won't have to type in WIF everytime? Currently, it looks to me the login function is a bit fake... Look, I wished I can do this: LOL
- I would love to see a few unit tests in such kind of project - and it will be great if you can use
travis-ci.comto set up a build system to boost some confidence. - It might be useful to consider using some front-end frameworks such as Vue or React, currently I can see you have some code mixing the presentation and logics using jQuery.
Great work!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
The purpose of login function is to save the username and memo key to localStorage so that I can use it while sending account update data and auto-filling forms. But I should have done the username verification. Thank you for pointing it out.
I think SteemConnect login cannot help with the functionalities because we are changing authorities but it might be a way to verify if the user owns the username.
I am planning to learn unit testing and going to use it in future projects.
Thank you so much for the detailed review. :)
Thank you for your review, @justyy! Keep up the good work!