You are viewing a single comment's thread from:
RE: WooCommerce Steem Payment Method Now Queries 3 Exchanges for STEEM/SBD Prices - 17 March 2019
Thank you for your contribution.
- I would suggest you manage your commits via Pull Requests i.e. you can create a branch and submit a PR to merge to your master branch - this way the branch will contain more descriptive commits instead of single big commit.
- You three exchanges could all extend to a interface which has a
query_ratesfunction signature. So you code will be much more organized later when you want to switch exchanges. - You might want to look at the APIs from
coinmarketcapthat can be used to convert between any two currencies/fiat - not use USD/BTC, BTC/STEEM, or BTC/SBD - Getting medians may be better than averaging the rates from exchanges . Sometimes, one exchange may show up abnormal rates because of pumping.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Hi @justyy. Thank you so much, your comment is packed with helpful suggestions. I appreciate them all and you got me thinking about a few things from different angles, so I appreciate that!
RE #4 I am curious if you are implying calculating median rates weighted by volume or simply taking the middle rate? Definitely want to avoid pumping rates if it is possible, so I value your feedback.
Actually that is related to the reason why we are choosing trusted exchanges vs CoinMarketCap - some people do not trust coinmarketcap to always be an accurate representation. But after reading your comment I can see the value in offering it as a choice, or perhaps treating it as another exchanges from which to choose the median.
Thank you for your review, @justyy! Keep up the good work!