You are viewing a single comment's thread from:
RE: (Part 11) Ethereum Solidity - Multisig Contract As Bank,k Multiple Users, And Where To Implement App Logic(PT 11)
Another beautiful tutorial, thank you.
I like the simplicity in delivering the ideas and concepts.
Couple of notes:
- I did not see the aspect of multi-sig implemented here. I guess you're just referring to the concept now under the Bank umbrella, and this would be referenced under other work?
- I suggest instead of just putting links to your other work, is to use markdown approach which make the display much neater, via using square brackets containing a word about the link [WORDS HERE ] , followed directly by brackets (LINK HERE), so that the final outcome would be [REF WORDS] (LINK) (remove space between them to actually work as a link).
- Also any images you used, either put some relevant references, or if they are CC mention that.
- One point to ask about decreasing the user balance when sending funds, is there a potential for the sending function to fail, and hence a need to do a rollback on the decrease in user balance? or that scenario could never happen?
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Hi, thank you for the review and for pointing where I can pay closer attention
Regarding the first point, I tried to approach the characteristic of multisig under the "bank" example to show how different wallets can have different stake on a contract balance, I will further cover this is the future but I need to think of better examples, though I think the bank example was good to show how different stakes can easily be defined on a contract
On your last point, according to the logic I have implement I don't think such error can occur because the only way this could happen is if the user tries to withdraw more than the contract has in balance but I can't think right now how could that happen without triggering errors before the change in balances.
That said, I have warned on the beginning of the tutorial that the goal of the tutorial is to demonstrate a sple implementation of a multisig wallet, not to go us on security or safe math. But if someone wants to be extra sure he can wrap every line of code inside a
requirefuntion, that would roll back the function and everything in case an error occursPosted using Partiko Android
Thank you for your review, @mcfarhat! Keep up the good work!