[Kahla Notify] [V2.0.2] The app can't handle when I tried to log in by filling every field empty
Related Informations
- Repository: https://github.com/AiursoftWeb/Kahla-Notify
- Project Name: Kahla Notify
- My Submitted Issue: here
- My GitHub Account: here
- Fixed Commit: here
Expected behavior
I expected that the app would notify me or warn me when I click on the login after filling all fields blank.
Actual behavior
When I clicked on the login button after letting all fields empty, then the app crashed.
How to reproduce
Here is every possible detail to reproduce the bug.
- Open the app.
- The login page will arrive. Clear all the fields and click on the login.
- Notice the error.
- App version: 2.0.2
- Operating system: Android 6.0.1
Recording Of The Bug
LogCat
05-26 13:43:00.241 27643 27643 E AndroidRuntime: FATAL EXCEPTION: main
05-26 13:43:00.241 27643 27643 E AndroidRuntime: Process: com.ganlvtech.kahlanotify, PID: 27643
05-26 13:43:00.241 27643 27643 E AndroidRuntime: java.lang.IllegalArgumentException: Expected URL scheme 'http' or 'https' but no colon was found
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at okhttp3.HttpUrl$Builder.parse(HttpUrl.java:1333)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at okhttp3.HttpUrl.get(HttpUrl.java:916)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at com.ganlvtech.kahlanotify.kahla.BaseService.newHttpUrlBuilder(BaseService.java:27)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at com.ganlvtech.kahlanotify.kahla.BaseService.newRequestBuilder(BaseService.java:33)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at com.ganlvtech.kahlanotify.kahla.AuthService.newAuthByPasswordCall(AuthService.java:64)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at com.ganlvtech.kahlanotify.client.KahlaClient.login(KahlaClient.java:275)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at com.ganlvtech.kahlanotify.LoginActivity.login(LoginActivity.java:152)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at com.ganlvtech.kahlanotify.LoginActivity.access$200(LoginActivity.java:17)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at com.ganlvtech.kahlanotify.LoginActivity$5.onClick(LoginActivity.java:93)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at android.view.View.performClick(View.java:5714)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at android.widget.TextView.performClick(TextView.java:10932)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at android.view.View$PerformClick.run(View.java:22589)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:739)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:95)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at android.os.Looper.loop(Looper.java:148)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:7325)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
05-26 13:43:00.241 27643 27643 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
Hi @sagorahmed, thanks for making this contribution.
This a good find, an error prompt should have been thrown when no details were provided in the input fields. I see the PO has fixed the issue in the commit you shared above. The logcat you provided was very helpful. It correctly pointed out the cause of the crash.
I look forward to more of your reports.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @fego! Keep up the good work!
Hi @sagorahmed!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
Hey, @sagorahmed!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!