[1ramp] [v0.0.13 revision 2] shows wrong error everytime, when user tries to power up.
Project Information
Repository: https://github.com/hapramp/1Rramp-Android
Project Name: 1Ramp
Expected behavior
It is expected that when user will try to power up, the app should able user to power up until user does any mistake like amount is 0.000 or less than 0.001 or more than that amount which user is actually having.
Actual behavior
Whenever user tries to power up with any amount it shows the same error every time- Amount should be greater than or equal to 0.001
. It happens every time even if user types an amount within balance range.
How to reproduce
Enter into the app and go on your profile
There you will see
GO TO WALLET
button on upper right side. Click on itAfter clicking on the button you will see power up button on next page. Click on it
It will ask you to type the amount which you want to power up
Make sure you have more than or equal to 0.001 steem to power up.
Type an amount within your balance range and Click on continue
A toast error message will appear with the message-
Amount should be greater than or equal to 0.001
Technical analysis
}
double amount = Double.parseDouble(inputAmount);
if (amount >= 0.001) {
toast("Amount should be greater than or equal to 0.001");
return false;
}
This issue is happening because of >=
sign. When user puts an amount>0.001 or amount=0.001 shows up the error. And as a result it was showing error for any amount within user's balance range.
FIx
This can be simple fixed by replacing >=
with <
.
Recording Of The Bug
- Device : Huawei y9
- Operating System : Android OREO(8.0.0)
- App Version : 1ramp Android Alpha v0.0.13 revision 2
Github Account
https://github.com/sourovafrin
Hi @sourovafrin, thanks for making this contribution.
I see the ticket you opened here has been attended to and fixed in this commit.
Feedback:
if (amount < 0)
to0.001
fixed the error. There was no "greater than or equal to">=
operator in the original expression.I hope this feedback helps. I look forward to your next contribution.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
You can see the full diff here- https://github.com/hapramp/1Rramp-Android/pull/173/files
The main point here is - your analysis and proposed fix was made and reported on Utopian after the PO already fixed it, You offered no help to the PO
Ahh, thanx. will try to add from next.
Thank you for your review, @fego!
So far this week you've reviewed 2 contributions. Keep up the good work!
Hi @sourovafrin!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
Congratulations! This post has been upvoted from the communal account, @minnowsupport, by sourovafrin from the Minnow Support Project. It's a witness project run by aggroed, ausbitbank, teamsteem, someguy123, neoxian, followbtcnews, and netuoso. The goal is to help Steemit grow by supporting Minnows. Please find us at the Peace, Abundance, and Liberty Network (PALnet) Discord Channel. It's a completely public and open space to all members of the Steemit community who voluntarily choose to be there.
If you would like to delegate to the Minnow Support Project you can do so by clicking on the following links: 50SP, 100SP, 250SP, 500SP, 1000SP, 5000SP.
Be sure to leave at least 50SP undelegated on your account.
Hey, @sourovafrin!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!